jextract/jni: Implement generic equals method#778
Merged
Conversation
ktoso
reviewed
Jun 2, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Neat! I wonder if we can nicely do hash code as well; otherwise we're breaking the contract of always having to implement "both"
Contributor
Author
|
I forgot to consider hashCode. |
Contributor
Author
|
Implemented |
Collaborator
|
Looks good, let’s add a test putting swift values into a java set maybe or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Java, every
Objecthas anequalsmethod.Conceptually, Swift's
Equatableprotocol serves the exact same purpose as Java'sequals.This PR implements a generic
equalsmethod, enabling allJNISwiftInstancetypes to leverage Swift'sEquatablecomparison directly through the standard Javaequalsmethod.